CMS MADE SIMPLE FORGE

Form Builder

 

[#3058] Bad IDs in *Email "From Address" Field, and send copy Disposition

avatar
Created By: Samuel Goldstein (sjg)
Date Submitted: Thu Feb 19 13:54:29 -0500 2009

Assigned To: Samuel Goldstein (sjg)
Version: 0.5.11
CMSMS Version: None
Severity: Minor
Resolution: Fixed
State: Closed
Summary:
Bad IDs in *Email "From Address" Field, and send copy Disposition
Detailed Description:
*Email "From Address" Field, and send copy generates IDs with [] which are not
valid (X)HTML. This needs to be fixed.


History

Comments
avatar
Date: 2009-03-11 09:07
Posted By: Ara Garabedian (aragee)

These errors are also happening on my site with the out of the box install of
FormBuilder.

Please fix ASAP!
      
avatar
Date: 2009-04-28 17:03
Posted By: Jean-Claude Etiemble (jce76350)

Hi,

Please see http://www.cmsmadesimple.fr/forum/viewtopic.php?pid=9114#p9114
Same problem
      
avatar
Date: 2009-04-28 19:59
Posted By: Simon (simonschaufi)

i made it valid (not yet in svn) but then the form doenst work again :(

here is my code:

if ($this->GetOption('send_user_copy','n') == 'c')
{
$retstr .= $mod->CreateInputCheckbox($id,'fbrp__'.$this->Id.'_2',
1,0,'id="'.$id.'fbrp__'.$this->Id.'_2" class="checkbox"');
$retstr .=
$mod->CreateLabelForInput($id,'fbrp__'.$this->Id.'_2',$this->GetOption('send_user_label',$mod->Lang('title_send_me_a_copy')),
'class="label"');
}
      
avatar
Date: 2009-05-11 13:34
Posted By: Simon Pieters (zcorpan)

[] in IDs are valid in (X)HTML5, FWIW.
      
avatar
Date: 2009-05-13 10:41
Posted By: Martin Hansen (Chinboy)

Did anyone get rid of this bug, or is there still no solution?
      
avatar
Date: 2009-06-02 10:52
Posted By: Harry Goz (nicetry)

This is a problem for me as well. If you need some help some testing or anything
I'll be available/in irc most days.
      
avatar
Date: 2009-09-07 19:43
Posted By: Samuel Goldstein (sjg)

fixed in svn.
      
avatar
Date: 2009-09-08 04:11
Posted By: Simon (simonschaufi)

Samuel, why did you enter hard coded HTML now and not used the functions for
that?
      
avatar
Date: 2009-09-08 13:39
Posted By: Samuel Goldstein (sjg)

The API doesn't allow me to set a different field name and field ID the way I
need to for this particular problem, so I kludged it :(
      
Updates

Updated: 2010-08-27 14:28
state: Open => Closed

Updated: 2009-09-07 19:43
resolution_id: => 7