CMS MADE SIMPLE FORGE

Form Builder

 

[#10470] Forms with "Email to User-Supplied Email Address" fail to send

avatar
Created By: Oliver341 (oliver341)
Date Submitted: Sun Mar 29 10:13:21 -0400 2015

Assigned To:
Version: 0.8.1.1
CMSMS Version: 1.11.13
Severity: Major
Resolution: Fixed
State: Closed
Summary:
Forms with "Email to User-Supplied Email Address" fail to send
Detailed Description:
The "Email to User-Supplied Email Address" field does not function correctly in
Form Builder. Whenever I submit a form, I just get a single unpopulated bullet
point above the form, presumably an attempt to display an error message, and
nothing gets sent.

My form xml available here:
http://forum.cmsmadesimple.org/viewtopic.php?f=7&t=72615

Upon further testing, I can see that this function works correctly in 0.8 but is
broken in 0.8.1 and 0.8.1.1.


History

Comments
avatar
Date: 2015-04-21 09:16
Posted By: Peter Tindemans (realrock)

Same problem here, no error visable and no e-mail get sent.

Any Solution for this problem?
      
avatar
Date: 2015-04-22 06:45
Posted By: Peter Tindemans (realrock)

A downgrade to 0.8 did indeed fixed the issue.
      
avatar
Date: 2015-05-02 12:43
Posted By: Sašo Živanović (avani)

I stumbled upon the same issue. I found the reason: function "Validate" of class
"fbDispositionDeliverToEmailAddressField", defined in
classes/DispositionDeliverToEmailAddressField.class.php was changed with the
purpose of starting to use  "email_validator" for email validation. However, an
(almost syntactic...) error was introduced in the code. Here's the definition of
"Validate" function that works properly. (It is also cleaned up, in the sense
that old commented-out code is deleted.)


	function Validate()
	{

  		$this->validated = true;
  		$this->validationErrorText = '';
		$result = true;
		$message = '';
		$mod = $this->form_ptr->module_ptr;
    
		if ($this->Value !== false && !email_validator::is_email($this->Value))
		  {
		    $this->validated = false;
$this->validationErrorText =
$mod->Lang('please_enter_an_email',$this->Name);
		  }

		return array($this->validated, $this->validationErrorText);
	}


P.S. Validation in DispositionFromEmailAddressField.class.php still does the job
the "old" way, without employing "email_validator".
      
avatar
Date: 2015-05-22 03:56
Posted By: Peter Tindemans (realrock)

Perfect Sašo, thanks for the code adjustment!
      
avatar
Date: 2015-08-04 14:20
Posted By: Jeff Bosch (ajprog)

Fixed in SVN
      
avatar
Date: 2016-01-16 15:20
Posted By: Rolf (rolf1)

Formbuilder 0.8.1.3 is released
      
Updates

Updated: 2016-01-16 15:21
state: Open => Closed

Updated: 2015-08-04 14:20
resolution_id: 5 => 7

Updated: 2015-03-31 10:42
cmsms_version_id: 30607 => 30644

Updated: 2015-03-31 10:42
description: The "Email to User-Supplied Email Address" field does not function correctly in Form Builder. Whenever I submit a form, I just get a single unpopulated bullet point above the form, presumably an attempt to display an error message, and nothing gets sent. => The "Email to User-Supplied Email Address" field does not function correctly in Form Builder. Whenever I submit a form, I just get a single unpopulated bullet point above the form, presumably an attempt to display an error message, and nothing gets sent.
resolution_id: => 5