Date: 2012-09-23 05:57
Posted By: Prue Rowland (psy)

Thanks Patrick, and yes a comma separated list is the standard.  This was a
'feature' I inherited from the original SEOTools module.

The next release of SEOTools2 will switch from " " to "," for keyword lists. 

It is *not a simple matter* as much of the behind-the-scenes stuff at present
relies on a space separated list. I also have to take into consideration how to
upgrade older versions of SEOTools2 to accommodate the change.  All in the
pipeline.

Please be patient. It will happen. :)
psy



      

Date: 2012-09-23 07:19
Posted By: Patrick Schoenbach (pschoenb)

For upgrading, I'd suggest the following:

If keyword list does not have any "," at all, replace " " -> ","
      

Date: 2012-09-23 07:48
Posted By: Prue Rowland (psy)

Hehe, if only it was that simple! It isn't.

The next release in SVN (v1.2) is still VERY buggy on some features (not this
one),but  does replace the spaces with commas, and correctly upgrade older
sites, and does the SEOTools/SEOTools2 thingy about avoiding keyword
spamming,...

As mentioned before, please be patient.  The next release will have some major
changes, including this one.
      

Date: 2012-11-13 09:51
Posted By: Metamorphose (metamorphose)

Hello

The version 1.2 from the SVN works now with a comma separated list, but the
keyword counter has a bug. For correct counting of keywords a white space is
needed before the keyword.

keyword1,keyword2,keyword3,keyword4   --> Counter gives 1
keyword1, keyword2, keyword3, keyword4   --> Counter gives 4



      

Date: 2012-11-13 14:54
Posted By: Prue Rowland (psy)

Thanks metamorphose. Fixed in SVN.
      

Date: 2012-11-17 05:30
Posted By: Metamorphose (metamorphose)

Hello Prue

Sorry, it doen't work. The counter only works with white spaces after comma.
Comma-.separated list without white-spaces are counted only as 1 keyword


      

Date: 2012-11-18 17:26
Posted By: Prue Rowland (psy)

Please try latest version of function.admin_pagesettings_tab.php in SVN.

Keyword count now works correctly for me for both custom and auto generated
keywords.  Would appreciate your confirmation it is OK for you too.

Regards
Prue

      

Date: 2012-11-19 16:19
Posted By: Metamorphose (metamorphose)

Sorry, not for me:

White spaces are not needed beetween keywords.

Example 1:
this,is,only,sample,text,keywords
--> must be 6 keywords
--> your module counts 1

Example 2:
this,is only,sample text,keywords
--> must be 4 keywwords
--> your module counts 1

Example 3
this, is only, sample text, keywords
--> must be 4 keywords
--> your module counts 4

Do I don't understand anything? Is it a must for a white space after a comma?
Auto-generated keywords counts correctly, because the keywords a written with a
white space after a comma too.
      

Date: 2012-11-19 17:17
Posted By: Prue Rowland (psy)

OK, am with you now. You're referring to custom keywords that do not have spaces
after the comma in the textarea list on the keyword edit screen.

Latest version in SVN correctly counts these words regardless whether there is a
space or not, at least in my testing. Would again appreciate feedback to ensure
it's working for you too.

Thanks for persisting with this.  It all helps to make SEO2 a better module. :)

Cheers
Prue
      

Date: 2012-11-20 13:19
Posted By: Metamorphose (metamorphose)

Hi Prue

Sorry, it doesn't work. In the release 1.2 you've changed to a comma-separated
list instead of space separated (and this is right so, keywords are usually
separated with a comma) but the keyword-counter searches further for spaces, in
my scenario only manually edited keyword lists

I've viewed your code and I think I've found the problem. When I change
function.admin_pagesettings_tab.php on line 115 with the following the counter
works

$keywords = '<b>'.count(explode(',',$info['keywords']))...................

I've replaced the space with a comma in the explode function.

Regards

      

Date: 2012-11-28 08:43
Posted By: Metamorphose (metamorphose)

Hi Prue

With revision 55 the counter works fine now, thank you.