CMS MADE SIMPLE FORGE

CMS Made Simple Core

 

[#9169] CMS DB update scripts do not fail when they should.

avatar
Created By: (htit)
Date Submitted: Thu Apr 18 01:09:08 -0400 2013

Assigned To:
Version: None
CMSMS Version: None
Severity: Minor
Resolution: None
State: Open
Summary:
CMS DB update scripts do not fail when they should.
Detailed Description:
I just upgraded a system that went from 35 to 36. 

There are lines like:
$return = $dbdict->ExecuteSQLArray($sqlarray);
$ado_ret = ($return == 2) ? ilang('done') : ilang('failed');
echo '[done]</p>';

I don't know if you do any checks for failures, but it sure would be a good
idea.
echo '[done]</p>'; is very misleading. At least it should be echo ($return == 2)
? "done" : "failed";
Probably better error checking is an order. It would be good if the error
messages would "bubble up" to the output some how if no error checking is being
done. Right now it's completely misleading and the next step fails leaving you
stuck with no information on why it's failing.


History

Updates

Updated: 2013-04-18 06:33
resolution_id: => 5
severity_id: 2 => 3