CMS MADE SIMPLE FORGE

SEOTools2

 
Back Back to List

[#8404] Problem with 'og:image' tag

avatar
Created By: Chris (caciavar)
Date Submitted: Sat Sep 15 15:58:31 -0400 2012

Assigned To:
Version: 1.1
CMSMS Version: 1.11.1
Severity: Minor
Resolution: Accepted
State: Open
Summary:
Problem with 'og:image' tag
Detailed Description:
The og:image metatag is created with  trailing double quotes when a single quote
is required (the double quote is after logo.png):

<meta property='og:image'
content='http://www.sitename.com/uploads/images\logo.png">

This is the Raw Open Graph Document Information from the facebook debugging tool
(which is an invalid, broken link to the image):

Meta Tag:	<meta property="og:image"
content="http://www.sitename.com/uploads/images\logo.png&quot;&gt; &lt;meta
property=" />

Notice that because the single quote after content= is not closed by another
single quote after logo.png, it looks for the next single quote which is
actually inside the next OG tag that is created:

<meta property='og:site_name' content='My Site'>

The fix should be to replace the double quote with a single quote in the
og:image tag that is generated.


History

Comments
avatar 
Date: 2012-09-15 16:19
Posted By: Chris (caciavar)

In action.default.php:

line 286:
content='".$config['image_uploads_url'].DIRECTORY_SEPARATOR.$image.'"'
(single, double, single)

Should be:
content='".$config['image_uploads_url'].DIRECTORY_SEPARATOR.$image."'"
(double, single, double)
avatar 
Date: 2012-09-17 06:40
Posted By: Prue Rowland (psy)

Fixed in SVN.  Will be in the next released version (1.11.2).
Thanks for pointing this out.
Updates

Updated: 2012-09-17 06:56
resolution_id: 5 => 6

Updated: 2012-09-15 15:59
description: The og:image metatag is created with trailing double quotes when a single quote is required (the double quote is after logo.png):