CMS MADE SIMPLE FORGE

CMS Made Simple Core

 
Back Back to List

[#7172] cms_selflink urlparam urlencodes ? and =

avatar
Created By: Mario S (rotezecke) (rotezecke)
Date Submitted: Mon Nov 14 19:40:30 -0500 2011

Assigned To:
Version: 1.10
CMSMS Version: 1.10
Severity: Minor
Resolution: Fixed
State: Closed
Summary:
cms_selflink urlparam urlencodes ? and =
Detailed Description:
{cms_selflink page="$pageAlias" text="$letter" urlparam="?models=$letter"} 

used to produce this: 

http://test.wallaby.nimfm.org/products/downloads.html?models=G

since 1.10 it does:

http://test.wallaby.nimfm.org/products/downloads.html%3Fmodels%3DG


History

Comments
avatar 
Date: 2011-11-14 20:56
Posted By: Robert Campbell (calguy1000)

Just tested... no problems.
avatar 
Date: 2011-11-15 13:19
Posted By: Robert Campbell (calguy1000)

sorry... must've tested on the wrong site.  Took another look and I see the
problem.  Will be fixed for 1.10.2
avatar 
Date: 2011-11-23 05:01
Posted By: Leopold Talirz (leoteo)

Although the urlencode has been removed in CMSMS 1.10.2, there is now another
typo (I applied diff between 1.10.1 and 1.10.2):

in plugins/function.cms_selflink.php line 68 the second condition should read:
( strlen($params['urlparam']) > 0  )
avatar 
Date: 2012-03-02 09:36
Posted By: Ronny Krijt (ronnyk)

1.10.3 is released.
Updates

Updated: 2012-03-02 09:36
state: Open => Closed

Updated: 2012-03-01 16:52
resolution_id: 6 => 7

Updated: 2011-11-15 13:19
resolution_id: 11 => 6

Updated: 2011-11-14 20:56
resolution_id: => 11