CMS MADE SIMPLE FORGE

CMS Made Simple Core

 
Back Back to List

[#6436] MenuManager: wrong assignment of $node->depth

avatar
Created By: Matthijs de Bruin (Tygrinn)
Date Submitted: Wed Apr 27 12:21:23 -0400 2011

Assigned To: Ted Kulp (wishy)
Version: 1.9.4.1
CMSMS Version: None
Severity: Minor
Resolution: Fixed
State: Closed
Summary:
MenuManager: wrong assignment of $node->depth
Detailed Description:
The built-in MenuManager module of CMSMS 1.9.4.1 wrongly assigns depth values to
nodes:

The FillNode function residing in MenuManager.module.php states it's 6th and 7th
parameter as: &$prevdepth and $origdepth respectively. However, in each of the
three calls to this function from action.default.php, the 6th and 7th parameters
that are passed are both the same: $prevdepth and $prevdepth.

Replacing the 7th parameter with $origdepth as per the function declaration,
fixes the problem.


History

Comments
avatar 
Date: 2011-05-12 13:33
Posted By: Robert Campbell (calguy1000)

Fixed in svn.
avatar 
Date: 2011-10-22 10:26
Posted By: Ronny Krijt (ronnyk)

1.10 is released.
avatar 
Date: 2011-12-05 12:12
Posted By: Stéphane-Eymeric Bredthauer (Bredt)

Hi, 
Sorry, but the bug has partially been fixed.
In revidion 205 of action.default.php (MenuManager) :
line 227 the 7th parameter hase been replaced but not line 129 (childof case)

Thx
avatar 
Date: 2011-12-05 12:19
Posted By: Stéphane-Eymeric Bredthauer (Bredt)

Oups :

line 129 the 7th parameter hase been replaced but not line 227 (childof case)

Thx again !
Updates

Updated: 2011-10-22 10:26
cmsms_version_id: => -1
state: Open => Closed

Updated: 2011-05-12 13:33
resolution_id: => 7