CMS MADE SIMPLE FORGE

CMS Made Simple Core

 
Back Back to List

[#2812] Remove junk files from the main install package

avatar
Created By: Yury Zaytsev (zaytsev)
Date Submitted: Thu Dec 25 16:11:45 -0500 2008

Assigned To: Robert Campbell (calguy1000)
Version: 1.5.1
CMSMS Version: None
Severity: Trivial
Resolution: Fixed
State: Closed
Summary:
Remove junk files from the main install package
Detailed Description:
In 

cmsmadesimple-1.5.1-base.tar.gz

/admin/lang/sr_YU.nls-notused.php - pretty self-explanatory
/admin/xss_changes_to_admin.txt - probably not needed anymore?
/lib/filemanager/ImageManager/lang/nl.js - useless

Everything  in the subfolders of 

/modules/CMSMailer/phpmailer

with the exception of 

/modules/CMSMailer/phpmailer/language/phpmailer.lang-en.php

because as far as I guess the language support for phpmailer is not implemented
anyway. The other files are more or less harmless, but I don't think it's good
to be able to launch phpmailer unit test from outside on the production
machine?! (test folder)

/modules/TinyMCE/tinymce/jscripts/tiny_mce/langs
/modules/TinyMCE/tinymce/jscripts/tiny_mce/themes/advanced/langs

with the excpetion of en.js (he, ko, jp are useless as they're not implemented
anyway)

Just for the sake of completeness.


History

Comments
avatar 
Date: 2008-12-26 11:45
Posted By: Robert Campbell (calguy1000)

The language stuff works in phpmailer, 

and removing the other files is irrelevant.
avatar 
Date: 2008-12-26 16:34
Posted By: Yury Zaytsev (zaytsev)

Is irrelevant to what? What I am asking is to review the aforementioned set of
files and possibly remove some of them before the next (major or minor) release
so we won't have to do it by hand.

Thank you for the clarification that the language stuff works for phpmailer,
which is good, I was not sure about it, that's why I asked.

Leaving the unit test behind, however, might represent a security issue. Do you
understand that it can be used to anonymously mailbomb people?

And the language files like sr_YU.nls-notused.php are just cluttering the
distro.

Thanks.
avatar 
Date: 2008-12-27 15:52
Posted By: Pierre Morin (pierrem)

Hello,

I too find things like sr-YU.nls disturbing in the light official package. If
such thing is unnecessary and unused I don't understand why it stands in.

Pierre M.
avatar 
Date: 2009-02-16 12:53
Posted By: Ronny Krijt (ronnyk)

Do you think this tracker can be closed... The 2 first mentioned files are
deleted.
avatar 
Date: 2009-02-16 13:48
Posted By: Yury Zaytsev (zaytsev)

I am sorry, I thought that It was already closed!
Updates

Updated: 2009-02-16 13:48
resolution_id: 8 => 7
state: Open => Closed

Updated: 2008-12-26 11:45
resolution_id: => 8
assigned_to_id: 100 => 106