CMS MADE SIMPLE FORGE

CMS Made Simple Core

 

[#12661] page_selector - allow_all parameter not working

avatar
Created By: Chris Taylor (chrisbt)
Date Submitted: Wed Nov 01 14:21:59 -0400 2023

Assigned To: Chris Taylor (chrisbt)
Version: 2.2.18
CMSMS Version: 2.2.18
Severity: Minor
Resolution: None
State: Open
Summary:
page_selector - allow_all parameter not working
Detailed Description:
the allow_all parameter is not being used and is hard coded to true. In the tag
help this parameter is documented and states the default is false.


History

Comments
avatar
Date: 2023-11-01 14:27
Posted By: Chris Taylor (chrisbt)

fixed in svn

The fix does change the default functionality as the correct default is to not
include any inactive pages in the list. This change should not cause any issues.

In the core files the {page_selector} tag is only used in Search modules Options
tab, to select the default result page.

To test:
use Search Module, Options tab. Check which pages can be selected for 'Page for
individual module results'. De-activate a page, then reload the Search Module,
Options tab - the inactive page should no longer be in the list to select.
Then modify the default file /modules/Search/templates/options_tab.tpl to add
into the {page_selector} tag: allow_all=true - then check that the De-activated
page is agaiin available to select..
      
avatar
Date: 2023-11-01 14:29
Posted By: Chris Taylor (chrisbt)

Note: param allowcurrent NOT working still, param for_child not checked