CMS MADE SIMPLE FORGE

CMS Made Simple Core

 
Back Back to List

[#12657] CMS_Content_Block internally uses type property which collides with type parameter of e.g FilePicker

avatar
Created By: Ruud van der Velden (ruudvdvelden)
Date Submitted: Thu Oct 19 15:49:53 -0400 2023

Assigned To:
Version: 2.2.18
CMSMS Version: 2.2.18
Severity: Minor
Resolution: None
State: Open
Summary:
CMS_Content_Block internally uses type property which collides with type parameter of e.g FilePicker
Detailed Description:
From 2.2.19beta1:

lib\classes\internal\class.CMS_Content_Block.php line 154 and further

The smarty_compiler_moduleblock method sets the content block's type to
'module'.
However a few lines later it allows setting properties based on the parameters
used in the content_module tag.

If one uses the 'type' parameter, e.g. in {content_module module=FilePicker
block=video type=video} the internally used type of the content block will be
overwritten.
In the end cmsms will not display a content block when the type property has an
invalid value
 
see
lib\classes\contenttypes\Content.inc.php::display_content_block


History