CMS MADE SIMPLE FORGE

CMS Made Simple Core

 
Back Back to List

[#12292] showbase parameter of metadata tag doesn't accept boolean value

avatar
Created By: Ruud van der Velden (ruudvdvelden)
Date Submitted: Thu Apr 16 10:43:47 -0400 2020

Assigned To: Ruud van der Velden (ruudvdvelden)
Version: 2.2.14
CMSMS Version: 2.2.14
Severity: Trivial
Resolution: Fixed
State: Closed
Summary:
showbase parameter of metadata tag doesn't accept boolean value
Detailed Description:
lib\plugins\function.metadata.php

if (isset($params['showbase']))	{
		if ($params['showbase'] == 'false')	$showbase = false;  
}

The check for a STRING 'false' is confusing and IMO bad practice.

I'd suggest to check for a boolean value and still check for 'false' for
backwards compatibility.

if (isset($params['showbase']))	{
if ($params['showbase'] === false || $params['showbase'] == 'false')	$showbase
= false;
}

//UNTESTED!

NOTE:
if( isset($config['showbase']))  $showbase = $config['showbase'];
does it better but doesn't explicitly make it a boolean. Which might be a good
idea to do there.


History

Comments
avatar 
Date: 2020-09-18 10:37
Posted By: Ruud van der Velden (ruudvdvelden)

Fixed in SVN
avatar 
Date: 2020-11-03 14:30
Posted By: Rolf (rolf1)

CMSMS 2.2.15 has been released
Updates

Updated: 2020-11-03 14:30
state: Open => Closed

Updated: 2020-09-18 10:37
resolution_id: => 7
assigned_to_id: 100 => 18365