CMS MADE SIMPLE FORGE

Uploads

 

[#6502] When scanning directory also delete missing files from the database

avatar
Created By: (jamaa)
Date Submitted: 2011-05-20 07:13

Assigned To:
Resolution: None
State: Open
Summary:
When scanning directory also delete missing files from the database
Detailed Description:
The option to scan directories for newly added files that are not yet in the
database is very useful, in particular if you simultaneously use FTP for
transferring files.
However, the case where a file is deleted from a directory (via FTP) but still
remains in the database is currently not covered.
For this purpose, I extended the Uploads.module.php with a new function
RemoveMissingFiles() which is invoked if the ScanDirectory function discovers
that there are less files in the directory than there are corresponding records
in the database.
I can supply the source code if desired.

History

Comments
avatar
Date: 2014-05-06 10:46
Posted By:  (jamaa)

What does that mean? Was this feature request closed because the requested
feature was added to the module or was it closed because the requested feature
is not deemed suitable for inclusion? A reason for closing the feature request
would have been nice.

I'm kinda fed up with CMSMS right now. I have a number of sites running CMSMS
but I think I have to switch to a different CMS, mainly because it is near
impossible to keep up-to-date with the modules or to keep them working with the
current version of CMSMS. Almost all of the svn-repositories of the modules have
been deactivated or are hopelessly out-of-sync with the download packages, it's
hard to figure out which version of a module works with which version of CMSMS.
In short, I find the module system a little chaotic and it is taking up too much
of my time to keep them working / updated. I would suggest reviving the svn
repositories for the modules and making sure that the module code is committed
to the repositories and that proper tags / branches are kept.

Sorry about the off-topic, but the uncommented closing of my feature request was
kinda like the drop that made it overflow for me.

jamaa
      
avatar
Date: 2014-05-06 12:28
Posted By: Robert Campbell (calguy1000)

A:  The issue was closed because it was almsot 3 years old....
B:  SVN/Git is an option on each project.  Each developer has the option to use
his own repository, to make those repositories public.... or to take the
repositories private at any time.
C:  If you don't like how a module works, or if a module has a bug/issue and
you're not satisfied as to it's progress, or the way you perceive you are being
treated you can always take the module (it is open source), fork it, and support
it yourself.
D:  Your apparent dissatisfaction is probably due to not understanding how
things work, or how you are doing things.  Not necessarily any fault of CMSMS or
any third party module developer.
      
avatar
Date: 2014-05-09 05:16
Posted By:  (jamaa)

Thanks for the answer. (Am reopening this feature request just to make sure you
see this.) Would you care to elaborate on the reason for closing the feature
request? The fact that the feature request is old is not a valid reason, in my
opinion.

As it is, I have local changes to the code that include this feature request. As
you as the admin of this module decided to not use svn/git or to keep the
repository private, it is very cumbersome for me to integrate the updates that
you publish into my version of the code. If there was a public repository, I
could just pull your changes into my local copy, but instead I have to download
files, compare them to my version and apply changes manually. That's what
bothers me. You don't have a public repository for the code, thus making it
difficult for users to synchronize their own changes with yours and at the same
time you don't seem willing to accept other people's changes to the code (as
witnessed by the fact that feature requests including offers of supplying the
source code are first ignored and then closed without a comment for being
"old"). If you don't want to accept other people's code changes, then at least
make it easy for us to keep our changes locally and synchronize with yours using
a revision system (and this applies to a lot of the modules out there).

I'm just trying to be constructive and suggest improvements. So I guess I could
fork the module. But would that be for the greater good of the CMSMS
ecosystem/community? I believe not.
      
Updates

Updated: 2014-05-09 05:16
state: Closed => Open

Updated: 2014-05-06 12:14
state: Open => Closed

Updated: 2014-05-06 10:48
state: Closed => Open

Updated: 2014-05-02 14:27
state: Open => Closed

Updated: 2011-09-29 04:31
description: The option to scan directories for newly added files that are not yet in the database is very useful, in particular if you simultaneously use FTP for transferring files. However, the case where a file is deleted from a directory but still remains in the => The option to scan directories for newly added files that are not yet in the database is very useful, in particular if you simultaneously use FTP for transferring files. However, the case where a file is deleted from a directory (via FTP) but still remai
resolution_id: => 5