CMS MADE SIMPLE FORGE

Statistics

 

[#9425] PHP coding error

avatar
Created By: Prue Rowland (psy)
Date Submitted: Wed Jul 24 22:58:55 -0400 2013

Assigned To: Fernando Morgado (JoMorg)
Version: 1.1.3
CMSMS Version: None
Severity: Minor
Resolution: Fixed
State: Closed
Summary:
PHP coding error
Detailed Description:
There is a coding error in Statistics.module.php on line 467.  The word 'and' is
written instead of '&&'. It's not catastrophic but will fill your error log.

I did this to tidy it up a bit:

      // create keyword array
    //  if (($keywords[2] != '') and ($keywords[2] != ' ')) {
        $keyw2 = !empty($keywords[2]) ? trim($keywords[2]) : '';
        if (!empty($keyw2)) {
        
        $keywords = preg_replace('/"|\'/', '', $keywords[2]); // remove quotes
$keyword_array = preg_split("/[\s,\+\.]+/",$keywords); // create keyword
array
      }
      // save
    //  if ($search_engine != '') {
      if (!empty($search_engine)) {


History

Comments
avatar
Date: 2016-06-21 08:43
Posted By: Fernando Morgado (JoMorg)

Fixed, thanks.
      
Updates

Updated: 2016-06-21 08:43
resolution_id: => 7
cmsms_version_id: 30123 => -1
assigned_to_id: 100 => 12532
state: Open => Closed