CMS MADE SIMPLE FORGE

ScriptDeploy

 

[#6030] doesn't work without ini_set()

avatar
Created By: Jonathan Schmid (Foaly*)
Date Submitted: Sat Jan 22 20:46:19 -0500 2011

Assigned To: Jeremy Bass (jeremybass)
Version: RC 0.8
CMSMS Version: None
Severity: Critical
Resolution: Fixed
State: Open
Summary:
doesn't work without ini_set()
Detailed Description:
Module doesn't work on servers that have init_set() disabled.


History

Comments
avatar
Date: 2011-01-22 21:38
Posted By: Jeremy Bass (jeremybass)

hmm.. I'll get to this.. tk 
      
avatar
Date: 2011-01-23 12:45
Posted By: Jeremy Bass (jeremybass)

You know what it's only in one spot.. look to L 31 in ScriptDeploy.module.php
and change

ini_set('include_path', 
	dirname(__FILE__) . '/lib'
	. PATH_SEPARATOR . ini_get('include_path')
);

to:

set_include_path( 
	dirname(__FILE__) . '/lib'
	. PATH_SEPARATOR . ini_get('include_path')
);




that should clear that up..  otherwise I'll have to do so conversions 


If you can try that and let me know.. tk Cheers - Jeremy

      
avatar
Date: 2011-01-23 12:52
Posted By: Jeremy Bass (jeremybass)

errr. I meant 

set_include_path(dirname(__FILE__) . '/lib/');

that gets rid of the  ini_get()...
      
avatar
Date: 2011-02-03 17:59
Posted By: Jonathan Schmid (Foaly*)

I didn't get a notification on your reply that's why I was a long time coming.

set_include_path() is also deactivated in most shared host setups!

My workaround: constant instead of include_path.
      
avatar
Date: 2011-02-03 20:24
Posted By: Jeremy Bass (jeremybass)

Ok.. I ficed in the SVN.. looks good to go.. I used 

if (!class_exists('JSMin')) {
$JSMin = cms_join_path(cmsms()->config['root_path'],'modules',
			      'ScriptDeploy','lib','JSMin.php');
	require_once($JSMin);
}

in /lib/Minify/Javascript.php

and striped out the set_include_path()

that should do it, and it's working on my localhost.

Test if you can please and let me know.. tk for the help.. Cheers -Jeremy
      
avatar
Date: 2011-02-12 18:59
Posted By: Jonathan Schmid (Foaly*)

the version from svn isn't listed in my backend at all when I try to install
from scratch. same with SiteUtlities. don't know what I'm doing wrong.
      
avatar
Date: 2011-02-13 21:10
Posted By: Jeremy Bass (jeremybass)

Ok. I just updated both modules to make sure both were working locally and both
where on the svn.. SD should not show up till SU is installed.  Also just FYI SU
is not done and as is it's just supporting SD and you should use SU out right
for it's function just yet... I have some fat to cut on SU right before I
publish all the modules.

Let meknow how it goes please and I'l make sure the issues are corrected.  tk -J
      
avatar
Date: 2011-02-14 17:42
Posted By: Jonathan Schmid (Foaly*)

I figured out what was wrong: You registered your module as SiteUtlities.
ScriptDeploy requires SiteUtilities. So neither SiteUtilities nor ScriptDeploy
shows up!

BTW: Why aren't you using GetDependencies()?

I only get Fatal error: Class 'filehandling' not found in
C:\xampp\htdocs\modules\ScriptDeploy\function.admin_scriptlist_tab.php on line
24

After including lib/class.filehandling.php to SiteUtilities.module.php the
module works fine!
      
avatar
Date: 2011-02-14 17:55
Posted By: Jonathan Schmid (Foaly*)

curious, the fatal error only appears on windows localhost (where ini_set and
set_include_path are disabled) doesn't appear on a linux live system.
      
Updates

Updated: 2011-02-03 20:24
resolution_id: 6 => 7

Updated: 2011-01-22 21:38
resolution_id: => 6