CMS MADE SIMPLE FORGE

SiteMapMadeSimple

 

[#5741] dynamic sitemap is not accessible for search engines

avatar
Created By: Carsten Wiedmann (wiedmann)
Date Submitted: Tue Nov 23 16:51:38 -0500 2010

Assigned To:
Version: 1.2.2
CMSMS Version: None
Severity: Major
Resolution: None
State: Open
Summary:
dynamic sitemap is not accessible for search engines
Detailed Description:
As long as IsAdminOnly is true, no one can access e.g.
"/index.php?mact=SiteMapMadeSimple,1,default,0".

It might also be a good idea, that accessing the dynamic sitemap the module is
always outputting a xml to the browser and not updating a static sitemap.
  


History

Comments
avatar
Date: 2010-11-23 16:53
Posted By: Carsten Wiedmann (wiedmann)

---
Downloads/SiteMapMadeSimple-1.2.2/SiteMapMadeSimple/SiteMapMadeSimple.module.php
+++
public_html/cmsmadesimple-dev/modules/SiteMapMadeSimple/SiteMapMadeSimple.module.php
@@ -67,15 +67,6 @@
 
 
   /*---------------------------------------------------------
-   IsAdminOnly()
-   ---------------------------------------------------------*/
-  function IsAdminOnly()
-  {
-    return true;
-  }
-
-
-  /*---------------------------------------------------------
    GetHelp()
    ---------------------------------------------------------*/
   function GetHelp()

 --- Downloads/SiteMapMadeSimple-1.2.2/SiteMapMadeSimple/action.default.php 
+++ public_html/cmsmadesimple-dev/modules/SiteMapMadeSimple/action.default.php 
@@ -31,7 +31,7 @@
 
 $xmlfile = $this->GenerateSiteMap($params);
 
-if( !$this->GetPreference('static_sitemap') )
+if( isset($params['action']) || !$this->GetPreference('static_sitemap') )
   {
     $handlers = ob_list_handlers();
     for ($cnt = 0; $cnt < sizeof($handlers); $cnt++) { ob_end_clean(); }


      
Updates

Updated: 2010-12-09 17:47
resolution_id: 11 => 5

Updated: 2010-11-23 16:53
resolution_id: => 11