[#5536] Error message when emailing previous feedback posters

Created By: Paul Baker (paulbaker)
Date Submitted: Sat Oct 16 08:38:00 -0400 2010

Assigned To:
Version: 1.2.1
CMSMS Version: None
Severity: Major
Resolution: Accepted
State: Open
Error message when emailing previous feedback posters
Detailed Description:
Method to recreate bug:

Create a feedback form like this:

{CGFeedback key1="Pages" key2=$page_name titlerequired="0" emailrequired="0"}

Note emailrequired="0" - I don't *require* people to enter their email address,
it is up to them.

Submit some feedback by filling in the feedback form.  Enter "NoEmailHere" (or
any text that is not an email address).  Tick the box to notify you of any new
comments on the page.  Press submit.

(Yes, I know it is silly to ask to be notified but not give a correctly formed
email address....but users are sometimes silly...)

If your system is set to "Modererate all comments" as yes, then go to Calguys
Feedback Module and mark the comment as published.

Submit some more feedback, doesn't matter what.  This forces the CGFeedback code
to go through and send email to people who have asked to be notified about new

A message appears just above the message about successful submission of the
form.  Some text shows for each failed email in the system, in this case:

"Invalid address: NoEmailHere You must provide at least one recipient email

Presumably this is where some code is crashing when trying to send an email to

NOTE! There is also a security issue here, since whatever was typed in to the
email address box by previous users is displayed on the site to future users.
This is why I marked the severity as Major.


Date: 2010-10-18 00:19
Posted By: Robert Campbell (calguy1000)

I'm now checking for a valid email address before sending.
will need more testing though.
Date: 2010-10-18 11:23
Posted By: Paul Baker (paulbaker)

Thank you calguy. I am happy to help test if you can give me some replacement

Updated: 2010-10-18 00:19
resolution_id: => 6