CMS MADE SIMPLE FORGE

CGFeedMaker

 

[#5244] Dot is not adding into RSS links

avatar
Created By: Daniel Pospisil (aa007)
Date Submitted: Sun Aug 01 10:29:36 -0400 2010

Assigned To: Robert Campbell (calguy1000)
Version: 1.0.11
CMSMS Version: None
Severity: Major
Resolution: None
State: Open
Summary:
Dot is not adding into RSS links
Detailed Description:
The link that the system is creating now looks like this: Newsrss instead of
News.rss
I found the problem here (CGFeedMaker.module.php, line 273):
	if( !empty($defext))
	  {
	    $url = substr($url,0,strlen($url)-strlen($defext));
	    if( !endswith('.',$url) ) $url .= '.';
	  }  
this line: f( !endswith('.',$url) ) $url .= '.'; is inside o another if
statement. In the last release, the if statement was after if( !empty($defext))
... block. So i moved it like this:

	if( !empty($defext))
	  {
	    $url = substr($url,0,strlen($url)-strlen($defext));
	  }  
  if( !endswith('.',$url) ) $url .= '.';

and now it works.


History

Comments
avatar
Date: 2010-08-13 04:06
Posted By: René Helminsen (reneh)

Bug confirmed by my on 1.8.1 and latest stable module release 1.0.11.
Tested this fix - and also confirmed works for me.
      
avatar
Date: 2010-09-01 09:13
Posted By: Arjan de Wit (bob_basli)

This works for me too on 1.0.11 in CMSMS 1.8.2
      
avatar
Date: 2010-12-22 06:31
Posted By: Nathan Koren (nkoren)

Just want to give this one a bump -- this bug caused major headaches for me. Is
CGFeedMaker being updated?
      
avatar
Date: 2011-01-18 09:40
Posted By: bess (bess)

thank you everybody , you saved 3 of my sites ! (and a precious time) !
      
Updates

Updated: 2010-08-13 04:06
resolution_id: => 5