CMS MADE SIMPLE FORGE

Uploads

 

[#4181] key= no longer supported by upload form?

avatar
Created By: Lew Shepherdson (lew)
Date Submitted: Tue Oct 13 04:47:33 -0400 2009

Assigned To:
Version: 1.10.2
CMSMS Version: None
Severity: Major
Resolution: None
State: Open
Summary:
key= no longer supported by upload form?
Detailed Description:
It seems that in the reorganization transition from 1.6 >> 1.7 and beyond, that
the support for the key= parameter on the upload form was dropped.  The
'action.upload.php' file no longer set the $input_key Smart variable, and the
{$input_key} disappeared from the Upload template.

I find it hard to believe that it was just an oversight, as I could find no
evidence of any complaints in the bug tracking system or on the forums.

Was it dropped deliberately, or is it being done differently now?

In any case, I re-added the following lines back into action.upload.php just
after line 111:

// is there a key
if( isset( $params['key'] ) )
	{
		$smarty->assign('input_key',
						$this->CreateInputHidden($id, 'input_key', $params['key']));
	}

and then added {$input_key} back to my upload template, and it all seems to work
properly now.

However, I'm worried that this was a design change that I may have missed...
design change or oversight??

Lew


History