CMS MADE SIMPLE FORGE

Members Area Registration

 
Back Back to List

[#12715] Some left overs

avatar
Created By: Magal (magallo)
Date Submitted: Fri May 24 09:33:43 -0400 2024

Assigned To: Fernando Morgado (JoMorg)
Version: 1.0.2
CMSMS Version: 2.2.18
Severity: Critical
Resolution: Fixed
State: Open
Summary:
Some left overs
Detailed Description:
There are a couple of items that are braking the flow of MAMS:

1)
Registration Template 1:
{mod_action_url module=SelfRegistration action=default mode=sendanotheremail}

module=SelfRegistration


2) 

$this->RegisterRoute(
      '/[Mm]amsreg\/register\/(?P<returnid>[0-9]+)\/(?P<group>.*)$/',
      array('action' => 'signp')
    );
    $this->RegisterRoute(
      '/[Mm]amsreg\/confirm\/(?P<returnid>[0-9]+)\/(?P<mr_data>.*?)$/',
      array('action' => 'verify')
    );

should be:

    $this->RegisterRoute(
'/mams\/register\/(?P<returnid>[0-9]+)\/(?P<group>.*)$/', array('action'
=> 'signup')
    );
    $this->RegisterRoute(
'/mams\/confirm\/(?P<returnid>[0-9]+)\/(?P<mr_data>.*?)$/', array('action'
=> 'verify')
    );

signup was a typo and action register_link calls for $pretty_url =
"mams/register/{$returnid}/{$params['group']}";

hope this helps


History

Comments
avatar 
Date: 2025-10-27 05:36
Posted By: Fernando Morgado (JoMorg)

While point 1 is valid, point 2 isn't:
The action URIs should have the prefix of the module that handles it, not other,
with few exceptions:
a) both modules are being maintained by the same developer(s);
b) the prefix is not hard coded but handled as a user preference;

These are meant to prevent possible collisions when module developers choose
them. Even a) should be used with caution and is not recommended in most cases.

None of the above applies here, as there is no reason for the route to have the
prefix set to mams instead of mamsreg;

As for point 1: fixed in SVN and ready for release

Thanks
Updates

Updated: 2025-10-27 05:36
resolution_id: => 7