CMS MADE SIMPLE FORGE

CMSMSExt

 

[#12600] rendered code not minified in php 8.0

avatar
Created By: Matt Hornsby (DIGI3) (DIGI3)
Date Submitted: Fri Feb 10 12:01:23 -0500 2023

Assigned To:
Version: 1.4
CMSMS Version: 2.2.16
Severity: Trivial
Resolution: Fixed
State: Open
Summary:
rendered code not minified in php 8.0
Detailed Description:
{xtjs_render} should minify by default, but it is not in php 8.0.


History

Comments
avatar
Date: 2023-02-12 14:42
Posted By: Fernando Morgado (JoMorg)

The file cfg.inc in the CMSMSExt data folder was included in the release by
mistake with a few side effects:
- it would overwrite an existing file, in particular in cases where a migration
from CGExtensions included entries from config.php;
- the included file has settings that were mainly used for debugging purposes
and most likely won't reflect neither the original file if it existed nor the
default behavior of the module without the file;

The fix can be one of the following:
- change the entries in the <site_root>/modules/CMSMSExt/data/cfg.inc file as
needed or...
- rename or delete the said file;

In future releases the file will be named cfg_sample.inc just for documentation
purposes, and care will be taken to prevent the accidental inclusion of the file
in the distributed files. But the file won't be deleted on future upgrades so
the fix must be applied manually in all cases.

Thanks
      
Updates

Updated: 2023-02-12 14:42
resolution_id: => 7
severity_id: 12 => 4