CMS MADE SIMPLE FORGE

CMSMSExt

 
Back Back to List

[#12568] Feedback

avatar
Created By: tom (tomphantoo)
Date Submitted: Sat Oct 22 01:56:29 -0400 2022

Assigned To: Fernando Morgado (JoMorg)
Version: 1.2
CMSMS Version: None
Severity: Minor
Resolution: Fixed
State: Closed
Summary:
Feedback
Detailed Description:
crasher: class.FS if( \ in_array >> if( \in_array 

crasher here: PHP7.4+ class-property typehints (min. is 7.2.1)
and BTW (per PSR_12) "When present, the static declaration MUST come after the
visibility"

With those changes, I can confirm that the Slack#devteam-mentioned
module-manager quirk is gone

Also BTW, htmLawed 1.2.9 doesn't work on PHP8.1+ ($GLOBALS[] writing N/A)


History

Comments
avatar 
Date: 2022-10-22 10:31
Posted By: Fernando Morgado (JoMorg)

- class.FS is a minor tipo, fixed;
- Quote: "crasher here: PHP7.4+ class-property typehints (min. is 7.2.1)", not
quite sure what you mean, can you please elaborate?
- PSR is just a recommendation not a requirement, not too worried about that.
The fork is bound to have plenty of old code, I may change it as I find it.
- htmLawed 1.2.9 works fine on PHP 8.1+ -> $GLOBALS[] writing is available per
key. Overwriting, unsetting, or otherwise making mass changes to the $GLOBALS
array is what is no longer allowed.

Interdependently of the above:   the Slack#devteam-mentioned module-manager
quirk is a bug in ModuleManager not CMSMSExt,
It's fixed, just pending. Have a bunch of stuff to commit.
Updates

Updated: 2024-07-02 13:06
resolution_id: 6 => 7
state: Open => Closed

Updated: 2022-10-22 10:31
resolution_id: => 6
severity_id: 2 => 3