CMS MADE SIMPLE FORGE

SimpleSiteMgr

 

[#11688] won't work if $config is customized and inappropriate directory

avatar
Created By: Philippe Thomas (filto)
Date Submitted: Sun Dec 31 22:00:37 -0500 2017

Assigned To: Rolf (rolf1)
Version: 3.3.1
CMSMS Version: 2.2.5
Severity: Minor
Resolution: Won't Fix
State: Closed
Summary:
won't work if $config is customized and inappropriate directory
Detailed Description:
your module always search the SimpleSiteInfo file in "tmp/templates_c" directory
on others targets websites.

just where SimpleSiteInfo module wrote it.

But you have forgotten that on others targets websites,
$config['tmp_templates_c_location'] can vary,
as it's a config variable, it can be customized.

Moreover, $config['tmp_templates_c_location'] as described in CMSMS
documentation,
is a location where smarty can write its compiled templates and does not need to
be publicly browseable.
(in my mind, it SHOULD NOT be publicly browseable : chmod 700 as
$config['tmp_cache_location'])

i think that, SimpleSiteInfo module should write the file in
$config['public_cache_location']

and in SimpleSiteMgr module
when create a new site entry,
then it should need a field in order to indicate the relative directory where to
find the SimpleSiteInfo file.
as it can not guess $config['public_cache_location'] eventualy customized in
config...

Thanks for this module so powerfull for saving time during muti-websites
maintenance process


History

Updates

Updated: 2020-02-01 20:00
state: Open => Closed

Updated: 2019-06-02 09:26
resolution_id: => 8