CMS MADE SIMPLE FORGE

SEOTools2

 

[#7783] base href not set correctly when using ssl

avatar
Created By: Mark Steer (markSt)
Date Submitted: Wed Apr 04 12:41:23 -0400 2012

Assigned To: Prue Rowland (psy)
Version: 1.0.5
CMSMS Version: None
Severity: Major
Resolution: Fixed
State: Closed
Summary:
base href not set correctly when using ssl
Detailed Description:
Hello,

I've got a site which uses http & https pages, and there are a few issues when
using SEOTools2 with an ssl enabled page.  I've made a few small changes on my
copy of the module and wonder if you would consider incorporating them or
something like this in a future release?

The correct base href is not honoured if the page is ssl, I made the following
change in action.default.php:

// Show base?
if ($params['showbase'] != 'false') {
    if(empty($_SERVER['HTTPS'])) {
	    echo "<base href='".$gCms->config['root_url']."/' />\n";
    } else {
        echo "<base href='".$gCms->config['ssl_url']."/' />\n";
    }
}

Further down in the image-link section you were specifying the root_url config
variable again, I've just removed that and allowed the browser to work it out:

if (($img != -1) && ($img != ""))  {
      echo "<link rel='image_src' href='/uploads/images/".$img."' />";
    }


You would probably know if there are any other places which have  the root_url
similarly hardcoded, but if there are I would be grateful if they could be
adapted using one of the methods above.

Many thanks for a great module.


Mark.



History

Comments
avatar
Date: 2012-04-04 18:15
Posted By: Prue Rowland (psy)

Thanks for that. Fixed in 1.0.6
      
Updates

Updated: 2013-07-27 19:25
cmsms_version_id: 29495 => -1
state: Open => Closed

Updated: 2012-04-04 18:15
resolution_id: => 7