CMS MADE SIMPLE FORGE

Gallery

 
Back Back to List

[#7782] doesn't work with ssl without generating warnings

avatar
Created By: Mark Steer (markSt)
Date Submitted: Wed Apr 04 12:07:08 -0400 2012

Assigned To: Jos (josvd)
Version: 1.5.3
CMSMS Version: None
Severity: Major
Resolution: Won't Fix
State: Closed
Summary:
doesn't work with ssl without generating warnings
Detailed Description:
Hello,

I've got a site where the http & https pages are mixed throughout.  On the https
pages the url you construct for the template stylesheets is hardcoded to use
$config['root_url'], which makes many browsers complain.

I've temporarily worked around this by removing  the root_url value entirely and
allow the browser to work it out.  For example, from action.showrandom.php line
205-211:

// check if a css file exists and echo
if ( file_exists("modules/Gallery/templates/css/" . $template . ".css") )
{
//removed ' . $config['root_url'] . '
$template_metadata .= '<link rel="stylesheet"
href="/modules/Gallery/templates/css/' . $template . '.css" type="text/css"
media="screen" />
';
}

Maybe you can consider removing these hardcoded values where they appear and
allowing your fantastic module to work more easily with ssl enabled sites?

Many thanks,


Mark.


History

Comments
avatar 
Date: 2014-01-26 18:19
Posted By: Jason (Jase)

Agreed -  To make it work I removed all occurrences of ". $config['root_url'] "
THe assumption is that it is the root URL anyway.

You will also need to change the Java  Script template from:

<script type="text/javascript"
src="http://ajax.googleapis.com/ajax/libs/jquery/1.4.4/jquery.min.js"></script>

to

<script type="text/javascript"
src="https://ajax.googleapis.com/ajax/libs/jquery/1.4.4/jquery.min.js"></script>

(Example for "Slimbox")

Jase
avatar 
Date: 2019-10-05 19:42
Posted By: Jos (josvd)

all is ssl nowadays
Updates

Updated: 2019-10-05 19:42
resolution_id: => 8
cmsms_version_id: 29495 => -1
state: Open => Closed