CMS MADE SIMPLE FORGE

TinyMCE

 

[#7614] Using tablecontrols means you have a second toolbar row with just seperators.

avatar
Created By: Tann San (Tann San)
Date Submitted: Fri Feb 17 07:24:24 -0500 2012

Assigned To: Morten Poulsen (silmarillion)
Version: 2.9.6
CMSMS Version: None
Severity: Minor
Resolution: Accepted
State: Closed
Summary:
Using tablecontrols means you have a second toolbar row with just seperators.
Detailed Description:
I've noticed this for several versions and so I always implement the same fix
for it.  I thought I'd share it with the group so hopefully a more permanent
solution can be implemented.

The bug itself is if you tick "Allow table operations" on the Profiles page and
put a tablecontrols control on the first toolbar row.  When you do that the
table controls appear on the first row exactly as they should but the second row
shows 4 empty seperator tags.  The only solution without editing any code is to
allow the table controls to appear on the second row.

I always customise the admin toolbar and keep it all on a single row.  I don't
use tables most of the time but on the odd occasion that I do I've always
noticed the bug I described.

My work-around is to edit "TinyMCE.module.php" in the /modules/TineMCE directory
and comment out two "if" statements.  The first is on lines 681, 682 and 683:

if ($this->GetPreference("advanced_allow_tables", "0") == "1") {
          $this->smarty->assign("toolbar" . $toolbar, "tablecontrols");
        }

The second is on lines 703, 704 and 705:

if ($this->GetPreference("allow_tables", "0") == "1") {
          $this->smarty->assign("toolbar" . $toolbar, "tablecontrols");
        }

That means that it no longer automatically inserts the tablecontrols tag.  I
think a nicer solution would be to expand the "if" statement to say "if
allow_tables is set AND the tablecontrols tag has not been manually inserted
anywhere by the user THEN insert it".  I could probably suss this out on my own
but I'm on a tight deadline.


History

Comments
avatar
Date: 2012-04-04 18:22
Posted By: Morten Poulsen (silmarillion)

I see the point! I'll consider this and hopefully find some solutions which
satisfies all needs :) concerning TinyMCE and tables, that is...
      
avatar
Date: 2016-02-12 13:25
Posted By: Rolf (rolf1)

TinyMCE version 3.x is released, the module is a complete rewrite of all code.

Because of this, bug reports related to the old version are not relevant anymore
and will be closed. Please use the latest and finest release at your CMSMS 2.x
website and test again. If you feel like your issue still isn't fixed create a
new report. Thanks.
      
Updates

Updated: 2016-02-12 13:25
cmsms_version_id: 29321 => -1
state: Open => Closed

Updated: 2012-04-04 18:22
resolution_id: => 6
assigned_to_id: 100 => 113