CMS MADE SIMPLE FORGE

CMS Made Simple Core

 

[#11906] Typo-Error in class.moduleoperations.inc.php?

avatar
Created By: Georg Busch (nan)
Date Submitted: Sun Oct 07 08:30:36 -0400 2018

Assigned To:
Version: 2.2.8
CMSMS Version: 2.2.8
Severity: Trivial
Resolution: Fixed
State: Closed
Summary:
Typo-Error in class.moduleoperations.inc.php?
Detailed Description:
File: /lib/classes/class.moduleoprations.inc.php 
Function: LoadModules() 
Line: 802 

there it says:

if( isset($CMS_STYLESHEET) && !isset($CMS_STYLESHEET) ) continue;

obviously this weird condition will never be true ;-)
Not sure what you're trying to check here.

It seems to be related to the /admin/style.php (since there $CMS_STYLESHEET is
declared the first time) or to stylesheets at all since in
/plugins/cms_stylesheet.php the $CMS_STYLESHEET variable is temporarily set to 1
and after stylesheet processing back to 0 (and even unset afterwards) to tell
the core that you're not on css processing anymore.

From my understanding you try to avoid loading modules if stylesheets are
processed (for whatever reason), don't you?

However either this condition is obsolete or it should be changed to whatever
you try to achieve here.

Kind regards.


History

Comments
avatar
Date: 2018-11-25 08:54
Posted By: Robert Campbell (calguy1000)

fixed in svn, thanks
      
avatar
Date: 2019-01-30 04:34
Posted By: Rolf (rolf1)

CMSMS 2.2.9 is released.
      
Updates

Updated: 2019-01-30 04:34
state: Open => Closed

Updated: 2018-11-25 08:54
resolution_id: => 7