CMS MADE SIMPLE FORGE

CMS Made Simple Core

 

[#11829] system information, tabindex and accesskey issues (resolutions include)

avatar
Created By: Philippe Thomas (filto)
Date Submitted: Thu May 31 22:37:36 -0400 2018

Assigned To: Mathieu Muths (airelibre) (airelibre)
Version: 2.2.7
CMSMS Version: 2.2.7
Severity: Minor
Resolution: None
State: Open
Summary:
system information, tabindex and accesskey issues (resolutions include)
Detailed Description:
admin -> system information
Permission Information :  "tmp" directory is useless

if config.php is used to customized defaults values,
"tmp" can be used nowhere !

if you agree with this :

admin/systeminfo.php

L322 and 323 are useless
$dir = $config['root_path'] . DIRECTORY_SEPARATOR . 'tmp';
$tmp[0]['tmp'] = testDirWrite(0, $dir, $dir);


/*-------------------------------------------------------------------*/
all pages edit

tabindex wrong default setting and setting value process:

All pages have tabindex 0  value by default !

empty value can not be set to tabindex !

when editing a page, if tabindex is not set, it always show 0 value in the
field.
while It should show an empty field !

moreover, the tabindex value update process use value as integer,
so "empty" or "0" value are always save as "0" in database

L1803 lib/classes/class.ContentBase.php
// tab index
if (isset($params['tabindex'])) $this->mTabIndex = (int) $params['tabindex'];

this line always set 0 as value for tabindex.

in order to make difference between empty and 0 value.

// tab index
if (isset($params['tabindex']) and $params['tabindex'] != '') {
$this->mTabIndex = (int) $params['tabindex'];
}
else {
$this->mTabIndex = '';
}


/*-------------------------------------------------------------------*/
accesskey are always empty for all pages

lib/classes/class.ContentBase.php
line 2426 (missing " on beginning name attribute)

'<input type="text" name=accesskey" ...

correct
'<input type="text" name="accesskey" ...



History