CMS MADE SIMPLE FORGE

LISE

 

[#11796] Fix some PHP notices with PHP7.2+

avatar
Created By: Chris Taylor (chrisbt)
Date Submitted: Sun Apr 15 06:47:33 -0400 2018

Assigned To: Fernando Morgado (JoMorg)
Version: 1.3.1
CMSMS Version: 2.2.7
Severity: Minor
Resolution: Fixed
State: Closed
Summary:
Fix some PHP notices with PHP7.2+
Detailed Description:
Fix some PHP notices with PHP7.2+

[15-Apr-2018 06:25:27 Europe/London] PHP Warning:  count(): Parameter must be an
array or an object that implements Countable in
/home/x/public_html/modules/LISE/LISE.module.php on line 751

was:
      if( count( func_num_args() ) )
to:
      if( func_num_args() > 0 )



[15-Apr-2018 09:55:11 Europe/London] PHP Warning:  count(): Parameter must be an
array or an object that implements Countable in
/home/x/public_html/modules/LISE/LISE.module.php on line 463

was:
      if(count($this->use_hints) > 0)
to:
      if(!is_null($this->use_hints))


History

Comments
avatar
Date: 2019-01-26 04:09
Posted By: Rolf (rolf1)

Hey Fernando,

I can confirm this issue and working fix on:

CMSMS 2.2.9
LISE 1.3.1
PHP 7.2.14

Grtz. Rolf
      
avatar
Date: 2019-02-15 09:43
Posted By: Franck (knarf)

Confirmed also the issue and the fix on my side.
      
avatar
Date: 2019-02-20 09:09
Posted By: Martin Poettgen (map_1961)

Hi Chris. Thx so far. I did the changes you proposed in a recently upgraded
cmsms system (2.2.9.1)  and got  - after uploading the changed Lise.module.php
using PhP 7.31 another eror message:

Warning: "continue" targeting switch is equivalent to "break". Did you mean to
use "continue 2"? in
/homepages/16/d184975754/htdocs/mp-p/luftvideo_cms/lib/classes/class.moduleoperations.inc.php
on line 395

Warning: "continue" targeting switch is equivalent to "break". Did you mean to
use "continue 2"? in
/homepages/16/d184975754/htdocs/mp-p/luftvideo_cms/lib/classes/class.moduleoperations.inc.php
on line 402

This disappears when changing the System to PhP 7.2

Thx

map_1961
      
Updates

Updated: 2020-10-01 08:16
assigned_to_id: 100 => 12532
state: Open => Closed

Updated: 2019-10-08 10:45
resolution_id: => 7